Skip to content

Fix/concealer 7 #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged

Fix/concealer 7 #1582

merged 5 commits into from
Apr 21, 2025

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Apr 18, 2025

Description

Abstract

If any of the states /api/localization/initialization_state, /api/routing/state, and /api/operation_mode/state related to Autoware state is in UNKNOWN state, Autoware should be considered to be initializing. However, the current concealer::LegacyAutowareState is not like that. This pull request fixes that bug.

Background

This bug was introduced by #1549.

Details

None.

References

None.

Destructive Changes

None.

Known Limitations

None.

@yamacir-kit yamacir-kit added bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Apr 18, 2025
@yamacir-kit yamacir-kit self-assigned this Apr 18, 2025
Copy link

github-actions bot commented Apr 18, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@yamacir-kit yamacir-kit marked this pull request as ready for review April 18, 2025 08:12
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, waiting for green CIs

Copy link

Failure optional scenarios

Note

This is an experimental check and does not block merging the pull-request.
But, please be aware that this may indicate a regression.

scenario failed: execution_time_test
      <failure type="SimulationFailure" message="CustomCommandAction typed &quot;exitFailure&quot; was triggered by the named Conditions {&quot;update time checker&quot;, &quot;avoid startup&quot;}: {&quot;update time checker&quot;: Is the /simulation/interpreter/execution_time/update (= 0.005401000000000000418609591435) is greaterThan 0.005?}, {&quot;avoid startup&quot;: Is the simulation time (= 14.250000000000067501559897209518) is greaterThan 1.000000000000000000000000000000?}" />

Copy link

@yamacir-kit yamacir-kit merged commit 3a883a8 into master Apr 21, 2025
14 checks passed
@github-actions github-actions bot deleted the fix/concealer-7 branch April 21, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants